[PATCH] D93411: [GlobalISel] Transform sext (cmp pred, x, y) -> select (cmp pred, x, y) tval, 0

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:3152
+  if (ExtTy.isVector() ||
+      getTargetLowering().convertSelectOfConstantsToMath(ExtTy))
+    return false;
----------------
arsenm wrote:
> This doesn't check the inputs are constants? The name seems wrong
The goal here is to avoid //creating// a select of constants from an extend if it will be transformed back into an extend later. So, there's no reason to check for constants here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93411/new/

https://reviews.llvm.org/D93411