[PATCH] D93331: [ELF] Reject local-exec TLS relocations for -shared

[Fangrui Song via Phabricator via llvm-commits]

MaskRay marked 2 inline comments as done.
MaskRay added inline comments.


================
Comment at: lld/ELF/Relocations.cpp:1408
+    }
+  } else if (unsigned processed = handleTlsRelocation<ELFT>(
+                 type, sym, sec, offset, addend, expr)) {
----------------
jhenderson wrote:
> `handleTlsRelocation` has a number of `config->shared` checks. Can these be dropped given this new diagnostic?
No. The `config->shared` checks in `handleTlsRelocation` are about whether GD/LD/IE can be relaxed to IE/LE.

This check is about LE in -shared.

Actually, R_TLS should really be renamed to R_TPOFFSET to be less confusing and I am going to send such a patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93331/new/

https://reviews.llvm.org/D93331