[PATCH] D92445: [PowerPC] Add powerpcle target.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: clang/lib/Basic/Targets/PPC.h:358
       resetDataLayout("E-m:a-p:32:32-i64:64-n32");
+    else if ((Triple.getArch() == llvm::Triple::ppcle))
+      resetDataLayout("e-m:e-p:32:32-i64:64-n32");
----------------
redundant `()`


================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:971
   // PPC has no copy relocations and cannot use a plt entry as a symbol address.
-  llvm::Triple::ArchType Arch = TT.getArch();
-  if (Arch == llvm::Triple::ppc || Arch == llvm::Triple::ppc64 ||
-      Arch == llvm::Triple::ppc64le)
+  if (TT.isPPC())
     return false;
----------------
Drop this change.

The ppc32 code path was actually dead and I have deleted it about 2 weeks ago.


================
Comment at: clang/lib/Driver/ToolChains/Linux.cpp:146
+  case llvm::Triple::ppcle:
+    if (D.getVFS().exists(SysRoot + "/lib/powerpc-linux-gnu"))
+      return "powerpcle-linux-gnu";
----------------
Should it be powerpcle?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92445/new/

https://reviews.llvm.org/D92445