[PATCH] D93460: [dsymutil][DWARFLinker][NFC] Refactor usages of UniquingStringPool.

Alexey Lapshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 17 07:56:24 PST 2020


avl created this revision.
avl added reviewers: JDevlieghere, friss, aprantl, dblaikie.
Herald added a subscriber: hiraditya.
avl requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

That refactoring is helpful since it reduces data inter-dependencies.
Which is good for current implementation and even more good for
fully multi-thread implementation. The idea of the refactoring
is to delete UniquingStringPool from the global DWARFLinker level.
It is used to unique type names while ODR deduplication is done.
Thus we move UniquingStringPool into the DeclContextTree which
matched to UniquingStringPool usage scope.

golden-dsymutil/dsymutil 23787992
clang MD5: 7d9873ff94f0246b6ab1ec3e8d0f3f06

build-Release/bin/dsymutil 23921272
clang MD5: 7d9873ff94f0246b6ab1ec3e8d0f3f06


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D93460

Files:
  llvm/include/llvm/DWARFLinker/DWARFLinker.h
  llvm/include/llvm/DWARFLinker/DWARFLinkerCompileUnit.h
  llvm/include/llvm/DWARFLinker/DWARFLinkerDeclContext.h
  llvm/lib/DWARFLinker/DWARFLinker.cpp
  llvm/lib/DWARFLinker/DWARFLinkerDeclContext.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D93460.312502.patch
Type: text/x-patch
Size: 18305 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201217/533fa6b6/attachment.bin>


More information about the llvm-commits mailing list