[PATCH] D92879: [PowerPC] Materialize 34 bit constants with pli on Power 10.

Amy Kwan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 17 07:46:52 PST 2020


amyk accepted this revision as: amyk.
amyk added a comment.
This revision is now accepted and ready to land.

I just have a minor nit, but overall it looks good to me.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:1046
+
+  const PPCSubtarget &PPCSubTarget =
+      CurDAG->getMachineFunction().getSubtarget<PPCSubtarget>();
----------------
nit: I think the preference is to name this as `Subtarget` rather than `PPCSubTarget`  (As seen in https://reviews.llvm.org/D81623)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92879/new/

https://reviews.llvm.org/D92879



More information about the llvm-commits mailing list