[PATCH] D93292: [AArch64][SVE] Add optimization to remove redundant ptest instructions

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1394-1395
+
+  // If we've gotten past all the checks, it's safe to remove the ptest
+  // and use the flag-setting form of brkpb.
+  Pred->setDesc(get(NewOp));
----------------
paulwalker-arm wrote:
> What about:
> 
> If we pass all the checks, it's safe to remove the PTEST and either use the flags as they are prior to PTEST.  Sometimes this requires the tested PTEST operand to be replaced with an equivalent instruction that also sets the flags.
Updated to remove rouge "either".

What about:

If we pass all the checks, it's safe to remove the PTEST and use the flags as they are prior to PTEST. Sometimes this requires the tested PTEST operand to be replaced with an equivalent instruction that also sets the flags.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93292/new/

https://reviews.llvm.org/D93292