[PATCH] D92959: [ELF][PPC64] Detect missing R_PPC64_TLSGD/R_PPC64_TLSLD and disable TLS relaxation

[Stefan Pintilie via Phabricator via llvm-commits]

stefanp accepted this revision.
stefanp added a comment.
This revision is now accepted and ready to land.

Tested this on some actual legacy compiled code and it does what we want.
Only one minor question. Otherwise, LGTM.

Thank you MaskRay!



================
Comment at: lld/test/ELF/ppc64-tls-missing-gdld.s:3
-# RUN: llvm-mc --triple=powerpc64le %s --filetype=obj -o %t1.o
-# RUN: llvm-mc --triple=powerpc64 %s --filetype=obj -o %t2.o
-# RUN: ld.lld --shared --fatal-warnings %t1.o -o /dev/null
----------------
I see that the BE test was removed. Given that this test is getting bigger I think this is fine.


================
Comment at: lld/test/ELF/ppc64-tls-missing-gdld.s:90
+.globl _start
+_start:
+
----------------
Is this to get rid of the warning for `_start` ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92959/new/

https://reviews.llvm.org/D92959