[PATCH] D93209: [libObject, llvm-readobj] - Reimplement `ELFFile<ELFT>::getEntry`.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 17 03:43:52 PST 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with nit.

FYI, tomorrow is my last day working before my Christmas break. I'll be back in from around the 4th of January. I'll try to clear as much of my review backlog as possible, but apologies if I fail to get to everything.



================
Comment at: llvm/test/tools/llvm-readobj/ELF/relocations.test:503
+## Check that we report a warning when a relocation has a
+## symbol index past the end of the symbol table
+
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93209/new/

https://reviews.llvm.org/D93209



More information about the llvm-commits mailing list