[PATCH] D93400: [IRBuilder] Generalize debug loc handling for arbitrary metadata.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 17 03:40:21 PST 2020


fhahn added inline comments.


================
Comment at: llvm/include/llvm/IR/IRBuilder.h:231
+  /// Add all entries in MetadataToCopy to \p I.
+  void AddInstMetadata(Instruction *I) const {
+    for (auto &KV : MetadataToCopy)
----------------
lebedev.ri wrote:
> This should probably be `AddMetadataToInst()`/`SetInstMetadata()`/???,
> because i have already misread what this does.
Thanks, that name is much better! Changed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93400/new/

https://reviews.llvm.org/D93400



More information about the llvm-commits mailing list