[PATCH] D93372: [CSKY 3/n] Add bare-bones C-SKY MCTargetDesc

[Renato Golin via Phabricator via llvm-commits]

rengolin added inline comments.


================
Comment at: llvm/lib/Target/CSKY/MCTargetDesc/CSKYAsmBackend.h:12
+
+#include "MCTargetDesc/CSKYMCTargetDesc.h"
+#include "llvm/MC/MCAsmBackend.h"
----------------
zixuan-wu wrote:
> rengolin wrote:
> > Do you really need this include here?
> Yes, class MCTargetOptions is introduced by it.
Why not include `"llvm/MC/MCTargetOptions.h"` directly here?

Your target description header has some auto-generated code that could get really large.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93372/new/

https://reviews.llvm.org/D93372