[PATCH] D93400: [IRBuilder] Generalize debug loc handling for arbitrary metadata.

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

Ah no, i guess i'm reading this wrong. LG.
I'm not sure about C API changes, they are likely ABI/API breaking and may require more changs, you might want for whoever maintains that to comment.



================
Comment at: llvm/include/llvm/IR/IRBuilder.h:231
+  /// Add all entries in MetadataToCopy to \p I.
+  void AddInstMetadata(Instruction *I) const {
+    for (auto &KV : MetadataToCopy)
----------------
This should probably be `AddMetadataToInst()`/`SetInstMetadata()`/???,
because i have already misread what this does.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93400/new/

https://reviews.llvm.org/D93400