[PATCH] D92735: [Flang] [OpenMP] Add semantic checks for invalid branch into/from OpenMP constructs

Thu Dec 17 02:15:49 PST 2020

praveen marked 2 inline comments as done.
praveen added a comment.

In D92735#2459786 <https://reviews.llvm.org/D92735#2459786>, @sameeranjoshi wrote:

>> Please suggest.
>
> Please see D93447 <https://reviews.llvm.org/D93447> if it helps in this patch.
> I am unaware of and haven't looked into how we can reuse code for branching inside maybe you can think/would be better how we could reuse the code already present.
> Also do look into `NoBranchingEnforce` if we can reuse.

@sameeranjoshi Yes . I had initially thought of the same change as in https://reviews.llvm.org/D93447 using the existing 'NoBranchingEnforce' as it would handle the branching out of the construct part . But since it wasnt able to identify the branching into the constructs , I made the changes in resolve-directives.cpp as part of this patch.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92735/new/

https://reviews.llvm.org/D92735