[PATCH] D92468: [ARM] Harden indirect calls against SLS

[Oliver Stannard (Linaro) via Phabricator via llvm-commits]

ostannard added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:698
     return false;
+  if (ST.hardenSlsBlr() && isIndirectCall(MI))
+    return false;
----------------
Should this be above the `return isV8EligibleForIT(&MI);`? (same comment as D92395)


================
Comment at: llvm/lib/Target/ARM/ARMSLSHardening.cpp:211
+        .addReg(ThunkReg)
+        .addImm(ARMCC::AL)
+        .addReg(ARM::NoRegister);
----------------
The `addImm`/`addReg` pair for the predicate can be done by `.add(predOps(ARMCC::AL))`, to be shorter and more self-documenting.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92468/new/

https://reviews.llvm.org/D92468