[PATCH] D92395: [ARM] Implement harden-sls-retbr for ARM mode

[Oliver Stannard (Linaro) via Phabricator via llvm-commits]

ostannard added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:341
 
-    // Skip over DEBUG values and predicated nonterminators.
-    while (I->isDebugInstr() || !I->isTerminator()) {
+    // Skip over DEBUG values and predicated nonterminators and speculation
+    // barrier terminators.
----------------
s/values and predicated/values, predicated/


================
Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:684
 
+  // Make indirect control flow changes unpredicable when SLS mitigation is
+  // enabled.
----------------
Should this be above the `return isV8EligibleForIT(&MI);` above?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92395/new/

https://reviews.llvm.org/D92395