[PATCH] D93342: Cleanup coro-inline.ll

[Xun Li via Phabricator via llvm-commits]

lxfind added inline comments.


================
Comment at: llvm/test/Transforms/Coroutines/coro-inline.ll:2
+; RUN: opt < %s -coro-early -always-inline -barrier -coro-split -S | FileCheck %s
+; RUN: opt < %s -passes='function(coro-early),always-inline,cgscc(coro-split)'  -S | FileCheck %s
+; RUN: opt < %s -sample-profile-file=%S/Inputs/sample.text.prof -pgo-kind=pgo-sample-use-pipeline -coro-early -sample-profile -coro-split -disable-inlining=true -S | FileCheck %s
----------------
dongAxis1944 wrote:
> always-inline should called before coro-early i think ???
This is where CoroEarly is added to the pipeline:
https://github.com/llvm/llvm-project/blob/7ea3932ab1def0f5e86ac745bef0d3de09e8845f/llvm/lib/Transforms/IPO/PassManagerBuilder.cpp#L299

This is where the inliner is added to the pipeline: https://github.com/llvm/llvm-project/blob/7ea3932ab1def0f5e86ac745bef0d3de09e8845f/llvm/lib/Transforms/IPO/PassManagerBuilder.cpp#L539

I tried to run Clang on a coroutine cpp file -O0, both let it print out the pass sequence and also set a few breakpoints. I saw that the CoroEarly pass is always executed before AlwaysInliner in the pipeline.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93342/new/

https://reviews.llvm.org/D93342