[PATCH] D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns.

[ChenZheng via Phabricator via llvm-commits]

shchenz added a comment.

I think it is better to explicitly give some reasons why we need this big refactoring, in other words, what's the disadvantage/limitation of legacy implementation? Thank you for the big effort.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.h:698
+
+      // Subtarget features.
+      MOF_SubtargetNoP9 = 1 << 26,
----------------
The following features should not be associated to one specific memory operation? Should we add them into the flag set of each memory operation in `computeMOFlags`? Is it possible to get the sub-target info when we do am selection after we get all flags?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93370/new/

https://reviews.llvm.org/D93370