[PATCH] D93427: [test] Cleanup some CGSCCPassManager tests

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/unittests/Analysis/CGSCCPassManagerTest.cpp:1809
+
+    for (LazyCallGraph::Node *N : Nodes) {
+      Function &F = N->getFunction();
----------------
rnk wrote:
> What do you think of this as an alternative code pattern for safe iteration of the nodes?
>   for (... N : std::vector<LazyCallGraph::Node*>(C.begin(), C.end())) { ... }
I initially attempted something like that, the issue is that `C.begin()`/`end()` return references and not pointers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93427/new/

https://reviews.llvm.org/D93427