[PATCH] D93423: [GlobalISel] Use slot indexes to speed up huge block compile time

Aditya Nandakumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 16 15:37:33 PST 2020


aditya_nandakumar added a comment.

In D93423#2458972 <https://reviews.llvm.org/D93423#2458972>, @arsenm wrote:

> I still think the CSE MIR builder shouldn't be required to CSE and can bail early on long dominance queries

I guess the concern is how exactly one defines "early" and "long". Should it be universal? Opt in? Configurable ?.. What if it bailed just a few instructions away from the target instruction. What about the compile time impact of counting and checking in loop in the cases where you don't need and so on.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93423/new/

https://reviews.llvm.org/D93423



More information about the llvm-commits mailing list