[PATCH] D89845: Add the ability to extract the unwind rows from DWARF Call Frame Information.

Wed Dec 16 15:30:54 PST 2020

clayborg marked 3 inline comments as done.
clayborg added inline comments.

================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp:920
+    DumpOpts.RecoverableErrorHandler(joinErrors(
+        createStringError(errc::invalid_argument,
+                          "decoding the CIE opcodes into rows failed"),
----------------
I found that DumpOpts had error handlers built in, so I used them. They are hooked up and caused a few tests that needed to be updated, so the error handling worked.

================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp:948
+  else {
+    DumpOpts.RecoverableErrorHandler(joinErrors(
+        createStringError(errc::invalid_argument,
----------------
I found that DumpOpts had error handlers built in, so I used them. They are hooked up and caused a few tests that needed to be updated, so the error handling worked.

================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp:433
+    return createStringError(errc::invalid_argument,
+                             "Operand index %" PRIu32 " is not valid.",
+                             OperandIdx);
----------------
jhenderson wrote:
> Looks like this message hasn't been reformatted with lower-case first letter and no full stop.
You are correct. I will fix.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89845/new/

https://reviews.llvm.org/D89845