[PATCH] D93241: [AArch64InstPrinter] Change printADRPLabel to print the target address in hexadecimal form

Wed Dec 16 14:03:05 PST 2020

MaskRay marked an inline comment as done.
MaskRay added inline comments.

================
Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp:1389
   if (Op.isImm()) {
-    O << "#" << formatImm(Op.getImm() * (1 << 12));
+    const int64_t Offset = Op.getImm() << 12;
+    if (PrintBranchImmAsAddress)
----------------
morehouse wrote:
> This line is causing a UBSan error:  http://lab.llvm.org:8011/#/builders/5/builds/2510
> Please fix.
> 
> ```
> /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp:1389:40: runtime error: left shift of negative value -32770
> ```
1bd928e50bb85a1ab8440473abd2a0a4ecd1349a

[Facepalm] C++20 :(

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93241/new/

https://reviews.llvm.org/D93241