[PATCH] D93229: [VectorCombine] allow peeking through GEPs when creating a vector load

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 16 13:38:22 PST 2020


lebedev.ri added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VectorCombine.cpp:160
+    OffsetInBits = Offset.getZExtValue() * 8;
+    Alignment = commonAlignment(Alignment, Offset.getZExtValue());
+  }
----------------
So we had `SrcPtr`, and split it into a base pointer `SrcPtr'`, and an offset `Offset`.
But i think it's `SrcPtr = SrcPtr' + Offset`,
so shouldn't the offset be negative here,
because the alignment is known for `SrcPtr`, not `SrcPtr'`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93229/new/

https://reviews.llvm.org/D93229



More information about the llvm-commits mailing list