[PATCH] D92958: [gn build] Add gn arg to only emit line numbers for debug info

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: llvm/utils/gn/build/BUILD.gn:75
 
+  assert(!(is_debug && is_debug_lines), "Cannot specify both is_debug and is_debug_lines")
   if (host_os != "win") {
----------------
I think this kind of suggests that what we have here is kind of a linear scale with a few steps, and controlling that via a collection of bools is a bit unwieldy.

Maybe we should get the route of having a `symbol_level` thing that can be 0, 1, or 2 (with 0 being the default for !is_debug builds, and 2 being the default for is_debug builds)? That'd match other GN-based builds, and it maps very clearly to a -g flag (at least on non-win clang).

And then my CL to turn on gdb indices would turn on indices for symbol level 2 (which would be the default for debug builds), and you could set `symbol_level=1` and everyone would be happy, maybe.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92958/new/

https://reviews.llvm.org/D92958