[PATCH] D54749: Saturating float to int casts.

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 16 12:22:33 PST 2020


bjope added a comment.

In D54749#2458355 <https://reviews.llvm.org/D54749#2458355>, @rjmccall wrote:

> I'm not entirely sure what you're still waiting for, really.  It's a big patch with a lot of diffuse responsibilities, but you've gotten sign-off from individual people across at least most of it.  Do you feel like there's something significant that hasn't been reviewed?

Well, I've just assumed that we should wait for an LGTM after the last fixups of earlier review comments.

But as you say, there haven't been any objections to adding the intrinsics, and there are no outstanding complaints. So maybe it is safe to assume that no one will object if I simply land this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54749/new/

https://reviews.llvm.org/D54749



More information about the llvm-commits mailing list