[PATCH] D92483: AMDGPU - Use MUBUF instructions for global address space access

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 16 12:03:44 PST 2020


rampitec added a comment.

In D92483#2458152 <https://reviews.llvm.org/D92483#2458152>, @pvellien wrote:

> if mcpu is specified, set Gen to the correct generation that cpu belongs to, by initializing it with SOUTHERN_ISLANDS.
> if mcpu is not specified (in this case GPU = "generic-hsa"), set Gen to the SEA_LANDS to be in parity with previous code> Comments inline

You are forcing SI for any SPECIFIED GPU instead:

  !GPU.contains("generic") ? SOUTHERN_ISLANDS 

Read this code line: if CPU is NOT generic, force it to SI.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92483/new/

https://reviews.llvm.org/D92483



More information about the llvm-commits mailing list