[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 16 11:45:58 PST 2020


dexonsmith added a comment.

In D83892#2458603 <https://reviews.llvm.org/D83892#2458603>, @dexonsmith wrote:

> Maybe it's worth defining another set of derived multiclasses, [...]

Another possibility of course is to make `Bool*Option` work this way (removing the ChangedBy, ResetBy, DefaultsToTrue, and DefaultsToFalse helpers).

(Either way, if we do add better support for dynamic defaults, I think the names `SetsTo{True,False}` are more clear than my previous example / suggestion `{True,False}Flag`.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83892/new/

https://reviews.llvm.org/D83892



More information about the llvm-commits mailing list