[PATCH] D93286: [RISCV] Define vslideup/vslidedown intrinsics and lower to V instructions.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/include/llvm/IR/IntrinsicsRISCV.td:118
+        : Intrinsic<[llvm_anyvector_ty],
+                    [LLVMMatchType<0>, LLVMMatchType<0>, llvm_any_ty,
+                     llvm_anyint_ty],
----------------
craig.topper wrote:
> Is the slideup/slidedown type always the same as the element type? Can we use LLVMVectorElementType<0> instead of llvm_any_ty?
I can't delete my previous comment. I think llvm_any_ty here should be llvm_anyint_ty and the tests should use i64 for rv64 and i32 for rv32.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93286/new/

https://reviews.llvm.org/D93286