[PATCH] D92645: [X86] Add X86ISD::SUBV_BROADCAST_LOAD and begin removing X86ISD::SUBV_BROADCAST (PR38969)

Wed Dec 16 10:55:42 PST 2020

craig.topper added inline comments.

================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:8971
+                                                   SDValue NewMemOpChain) {
+  assert(isa<MemSDNode>(NewMemOpChain.getNode()) && "Expected a memop node");
   // The new memory operation must have the same position as the old load in
----------------
Can you assert that the types for the inputs are MVT::Other?

================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:38145
+        TLO.DAG.makeEquivalentMemoryOrdering(SDValue(MemIntr, 1),
+                                             SDValue(Ld.getNode(), 1));
+        return TLO.CombineTo(Op, insertSubVector(TLO.DAG.getUNDEF(VT), Ld, 0,
----------------
Ld.getValue(1)?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92645/new/

https://reviews.llvm.org/D92645