[PATCH] D92672: [flang][openacc] Enforce restriction on routine directive and clauses

[Valentin Clement via Phabricator via llvm-commits]

clementval marked an inline comment as done.
clementval added inline comments.


================
Comment at: flang/test/Semantics/acc-routine-validity.f90:19
+
+  !ERROR: Internal: no symbol found for 'dummy'
+  !$acc routine(dummy) seq
----------------
sameeranjoshi wrote:
> clementval wrote:
> > sameeranjoshi wrote:
> > > Why isn't it getting resolved though having a resolving function defined above?
> > > Do you think there is a need for a more better resolver, which I tried in 
> > > https://reviews.llvm.org/D93051 with the latest diff?
> > `dummy` is not defined anywhere and must raise an error here. There is no subroutine/function named dummy so no symbol so the error is triggered. This is the correct behavior. Not all name can be resolved if they really do not exists. 
> So why is it an internal error, which seems to be a fatal error?
> Shouldn't it be something like `no declaration found` or the normal way we get errors from Fortran part in F18?
Well this is the Flang error for no symbol found why would you want a different error? I don't get your point here. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92672/new/

https://reviews.llvm.org/D92672