[PATCH] D92200: Ensure SplitEdge to return the new block between the two given blocks

[Whitney Tsang via Phabricator via llvm-commits]

Whitney added inline comments.


================
Comment at: llvm/unittests/Transforms/Utils/BasicBlockUtilsTest.cpp:281
+
+  ASSERT_DEATH(
+      {
----------------
kobeliu85 wrote:
> Meinersbur wrote:
> > kaz7 wrote:
> > > FYI, having failed to die error here.  I appreciate if you fix it.
> > I think the crash would be due to an `assert`, which are removed in release builds. We cannot directly test assertions.
> Thanks for the comment, I will investigate this today. 
Probably can guard this test case in `#ifndef NDEBUG`, just like in `CGSCCPassManagerTest.cpp`.
```
// The (negative) tests below check for assertions so we only run them if NDEBUG
// is not defined.
#ifndef NDEBUG
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92200/new/

https://reviews.llvm.org/D92200