[PATCH] D93403: AMDGPU: Remove SGPRSpillVGPRDefinedSet hack

[Scott Linder via Phabricator via llvm-commits]

scott.linder added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SILowerSGPRSpills.cpp:391
+  // Updated the reserved registers with any VGPRs added for SGPR spills.
+  if (NewReservedRegs)
+    MRI.freezeReservedRegs(MF);
----------------
Why is this `bool` needed? It seems like freezing the reserved regs is idempotent anyway. If anything I'd expect to just see `assert(MRI.reservedRegsFrozen())` to ensure you aren't running before regalloc, but maybe that's redundant?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93403/new/

https://reviews.llvm.org/D93403