[PATCH] D93051: [Flang][openmp] Add semantic checks for OpenMP critical construct.

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:369
   void ResolveOmpName(const parser::Name &, Symbol::Flag);
-  Symbol *ResolveName(const parser::Name *);
+  Symbol *ResolveName(const parser::Name *, Symbol::Flag);
   Symbol *DeclareOrMarkOtherAccessEntity(const parser::Name &, Symbol::Flag);
----------------
What's the big difference with `ResolveOmpName`. Merging the two functions would be better. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93051/new/

https://reviews.llvm.org/D93051