[PATCH] D92576: Remove insertDebugValuesForPHIs() from LCSSA to prevent assignments from being reordered

Nabeel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 16 08:01:29 PST 2020


n-omer updated this revision to Diff 312214.
n-omer added a comment.

`Transforms/LoopIdiom/X86/left-shift-until-bittest.ll` test was recently added in this commit <https://github.com/llvm/llvm-project/commit/45ddb245c50c2f3a109ad22174e9b52ad6de0ac7#diff-4498435c8a665a23e0159b1c6893d787978c65b2ee2848da572be661081982b5>. The test in its current form relies on LCSSA's current behaviour. I have updated the patch to remove that reliance.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92576/new/

https://reviews.llvm.org/D92576

Files:
  llvm/lib/Transforms/Utils/LCSSA.cpp
  llvm/test/Transforms/LCSSA/DontInsertDebugValuesForPHIs.ll
  llvm/test/Transforms/LCSSA/basictest.ll
  llvm/test/Transforms/LoopIdiom/X86/left-shift-until-bittest.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92576.312214.patch
Type: text/x-patch
Size: 16073 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201216/2a707dfa/attachment.bin>


More information about the llvm-commits mailing list