[PATCH] D92747: [DAGCombiner] Use getVectorElementCount inside visitINSERT_SUBVECTOR

[David Sherwood via Phabricator via llvm-commits]

david-arm added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:21109
+    unsigned Factor =
+        N1.getValueType().getVectorElementCount().getKnownMinValue();
     SmallVector<SDValue, 8> Ops(N0->op_begin(), N0->op_end());
----------------
You can use getVectorMinNumElements() here if you want?


================
Comment at: llvm/test/CodeGen/AArch64/dag-combine-insert-subvector.ll:28
+  %concat = shufflevector <4 x double> %a, <4 x double> %b, <8 x i32> <i32 4, i32 5, i32 6, i32 7, i32 0, i32 1, i32 2, i32 3>
+  %retval = call <vscale x 2 x double> @llvm.experimental.vector.insert.nxv2f64.nxv8f64(<vscale x 2 x double> undef, <8 x double> %concat, i64 0)
+  ret <vscale x 2 x double> %retval
----------------
The insert intrinsic expects a <vscale x 8 x double> here I think, right? i.e. nxv2f64.nxv8f64


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92747/new/

https://reviews.llvm.org/D92747