[PATCH] D93132: [SVE][CodeGen] Vector + immediate addressing mode for masked gather/scatter

[David Sherwood via Phabricator via llvm-commits]

david-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:3911
+    if (auto SplatVal = DAG.getSplatValue(Index.getOperand(1)))
+      if (isa<ConstantSDNode>(SplatVal)) {
+        Offset = cast<ConstantSDNode>(SplatVal);
----------------
nit: braces on if statement aren't need here


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:3924
+    std::swap(BasePtr, Index);
+    Opcode = NewOp;
+    return;
----------------
If the Offset is not a constant splat should we be using the IMM form here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93132/new/

https://reviews.llvm.org/D93132