[PATCH] D92089: [PowerPC] Materialize i64 constants by enumerated patterns.

Lei Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 16 05:27:24 PST 2020


lei added a comment.

Minor nit to be addressed upon commit. Thx!



================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:802
 
+// For any 32 < Num < 64, check if the Imm contains at least Num consecutive
+// zeros and return the number of bits by the left of these consecutive zeros.
----------------
nit: sentences should end with a '.'


================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:803
+// For any 32 < Num < 64, check if the Imm contains at least Num consecutive
+// zeros and return the number of bits by the left of these consecutive zeros.
+static int findContiguousZerosAtLeast(uint64_t Imm, unsigned Num) {
----------------
nit: Complete sentence please.  All sentences should start with a capital.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92089/new/

https://reviews.llvm.org/D92089



More information about the llvm-commits mailing list