[PATCH] D93392: [llvm][ARM/AArch64] Convert Target Parser CPU tests to fixtures

David Spickett via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 16 05:19:55 PST 2020


DavidSpickett added inline comments.


================
Comment at: llvm/unittests/Support/TargetParserTest.cpp:933
+                         "8.2-A"),
+        ARMCPUTestParams("cyclone", "armv8-a", "crypto-neon-fp-armv8",
+                         AArch64::AEK_NONE | AArch64::AEK_CRYPTO |
----------------
This is an example where the CPU has AEK_NONE for its additional extensions and the tests had a special path for that.

I don't think there's much merit to that so I've just added AEK_NONE for those CPUs that don't extend the base arch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93392/new/

https://reviews.llvm.org/D93392



More information about the llvm-commits mailing list