[PATCH] D93392: [llvm][ARM/AArch64] Convert Target Parser CPU tests to fixtures

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 16 05:06:26 PST 2020


fhahn added inline comments.


================
Comment at: llvm/unittests/Support/TargetParserTest.cpp:36
 
-bool testARMCPU(StringRef CPUName, StringRef ExpectedArch,
-                StringRef ExpectedFPU, uint64_t ExpectedFlags,
-                StringRef CPUAttr) {
+typedef std::tuple<const char * /*CPUName*/, const char * /*ExpectedArch*/,
+                   const char * /*ExpectedFPU*/, uint64_t /*ExpectedFlags*/,
----------------
Can a struct be used instead here? That would make things much more readable IMO/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93392/new/

https://reviews.llvm.org/D93392



More information about the llvm-commits mailing list