[PATCH] D93372: [CSKY 3/n] Add bare-bones C-SKY MCTargetDesc

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 16 04:36:41 PST 2020


rengolin added a comment.

Looks like a standard mock implementation, basic infrastructure. I don't see anything wrong with it but I've also been far from this area for too long, so I'll let other people review it properly and approve.



================
Comment at: llvm/lib/Target/CSKY/MCTargetDesc/CSKYAsmBackend.h:12
+
+#include "MCTargetDesc/CSKYMCTargetDesc.h"
+#include "llvm/MC/MCAsmBackend.h"
----------------
Do you really need this include here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93372/new/

https://reviews.llvm.org/D93372



More information about the llvm-commits mailing list