[PATCH] D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS

[Adhemerval Zanella via Phabricator via llvm-commits]

zatrazz added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/aarch64-symbols-stother.test:43-46
+  - Name: foo3
+    Other: [ STO_AARCH64_VARIANT_PCS, STV_INTERNAL ]
+  - Name: foo4
+    Other: [ STO_AARCH64_VARIANT_PCS, STV_INTERNAL, STV_HIDDEN ]
----------------
jhenderson wrote:
> The visibility bits aren't flags, they're values, so they can't be combined like you've done here (hence why you end up with STV_PROTECTED in the final output). I think as long as you've got the max visibility value (iSTV_PROTECTED) defined in one of these cases, I think that's all you need (you can then drop the other case).
> 
> You might also want a negative case, using STV_PROTECTED, to make sure the STO_AARCH_VARIANT_PCS value isn't used in this case.
> 
> Examples suggested with the inline edit.
Ack, I will change the tests with your suggestions.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93044/new/

https://reviews.llvm.org/D93044