[PATCH] D93390: [compiler-rt] [builtins] Fix name of __aarch64_have_lse_atomics on Darwin

Stephan Bergmann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 16 03:53:16 PST 2020


sberg created this revision.
sberg added reviewers: kubamracek, ilinpv, tambre, dmajor.
Herald added subscribers: danielkiss, jfb, kristof.beyls, dberris.
sberg requested review of this revision.
Herald added a project: Sanitizers.
Herald added a subscriber: Sanitizers.

...where the name of that variable defined in
compiler-rt/lib/builtins/cpu_model.c is decorated with a leading underscore


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D93390

Files:
  compiler-rt/lib/builtins/aarch64/lse.S


Index: compiler-rt/lib/builtins/aarch64/lse.S
===================================================================
--- compiler-rt/lib/builtins/aarch64/lse.S
+++ compiler-rt/lib/builtins/aarch64/lse.S
@@ -28,7 +28,11 @@
 .arch armv8-a
 #endif
 
+#if !defined(__APPLE__)
 HIDDEN(__aarch64_have_lse_atomics)
+#else
+HIDDEN(___aarch64_have_lse_atomics)
+#endif
 
 // Generate mnemonics for
 // L_cas:                                 SIZE: 1,2,4,8,16 MODEL: 1,2,3,4
@@ -106,8 +110,8 @@
         adrp    x(tmp0), __aarch64_have_lse_atomics
         ldrb    w(tmp0), [x(tmp0), :lo12:__aarch64_have_lse_atomics]
 #else
-        adrp    x(tmp0), __aarch64_have_lse_atomics at page
-        ldrb    w(tmp0), [x(tmp0), __aarch64_have_lse_atomics at pageoff]
+        adrp    x(tmp0), ___aarch64_have_lse_atomics at page
+        ldrb    w(tmp0), [x(tmp0), ___aarch64_have_lse_atomics at pageoff]
 #endif
         cbz     w(tmp0), \label
 .endm


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D93390.312170.patch
Type: text/x-patch
Size: 921 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201216/3163f865/attachment.bin>


More information about the llvm-commits mailing list