[PATCH] D93297: [lib/Object] - Make ELFObjectFile::getSymbol() return Expected<>.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 15 23:49:13 PST 2020
grimar marked an inline comment as done.
grimar added inline comments.
================
Comment at: llvm/include/llvm/Object/ELFObjectFile.h:414
+ EF.template getEntry<Elf_Sym>(Sym.d.a, Sym.d.b);
+ if (!EntryOrErr)
+ return EntryOrErr.takeError();
----------------
MaskRay wrote:
> Just `return EF.template getEntry<Elf_Sym>(Sym.d.a, Sym.d.b);`
Right, thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93297/new/
https://reviews.llvm.org/D93297
More information about the llvm-commits
mailing list