[PATCH] D93263: [lld-macho] Implement option: -undefined TREATMENT

[Greg McGary via Phabricator via llvm-commits]

gkm marked 3 inline comments as done.
gkm added inline comments.


================
Comment at: lld/MachO/SymbolTable.cpp:163
+  default:
+    fatal("malformed -undefined treatment");
+    return false;
----------------
gkm wrote:
> int3 wrote:
> > with the change suggested above, this could be `llvm_unreachable` instead of `fatal`
> I dropped `default:` entirely, because clang warns that it is unused as every enum case is explicitly handled.
I thought I could drop `unknown` from the enum, but that wasn't workable for giving a diagnostic on `StringSwitch<UndefinedSymbolTreatment>(...).Default(...)`, so `default: llvm_unreachable()` is necessary after all.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93263/new/

https://reviews.llvm.org/D93263