[PATCH] D93336: [PowerPC][NFC] Cleanup PPCCTRLoopsVerify pass

[ChenZheng via Phabricator via llvm-commits]

shchenz added a comment.

Thanks for clean-up. Some minor comments.



================
Comment at: llvm/lib/Target/PowerPC/PPCCTRLoops.cpp:16
+
+#include "MCTargetDesc/PPCMCTargetDesc.h"
 #include "PPC.h"
----------------
Seems now we only need following headers:
```
#include "MCTargetDesc/PPCMCTargetDesc.h"
#include "PPC.h"
#include "llvm/ADT/SmallSet.h"
#include "llvm/ADT/SmallVector.h"
#include "llvm/CodeGen/MachineBasicBlock.h"
#include "llvm/InitializePasses.h"
#include "llvm/Pass.h"
#include "llvm/Support/Debug.h"
#include "llvm/CodeGen/MachineDominators.h"
#include "llvm/CodeGen/MachineFunction.h"
#include "llvm/CodeGen/MachineFunctionPass.h"
```


================
Comment at: llvm/lib/Target/PowerPC/PPCCTRLoops.cpp:37
 
 #ifndef NDEBUG
 #include "llvm/CodeGen/MachineDominators.h"
----------------
Since now all the function body is guarded under `#ifndef NDEBUG`, should we guard other headers as well?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93336/new/

https://reviews.llvm.org/D93336