[PATCH] D93344: [flang] Handle multiple names for same operator
Peter Klausler via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 15 16:54:45 PST 2020
klausler added a comment.
In D93344#2456607 <https://reviews.llvm.org/D93344#2456607>, @tskeith wrote:
> In D93344#2456531 <https://reviews.llvm.org/D93344#2456531>, @klausler wrote:
>
>> Could the same effect be accomplished by instead canonicalizing `operator(...)` names in the output of the prescanner?
>
> Yes, and that would simplify life in `resolve-names.cpp`. But it would mean that a user that consistently used `operator(==)`, for example, might get diagnostics that refer to `operator(.eq.)` (or vice versa, depending on how we canonicalized). As it is, we use one of the names that appears in the source.
Sure, but we would still be quoting and underlining the original source, so the user experience wouldn't be a total loss. Let me know if this is something that you'd like me to try to do.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93344/new/
https://reviews.llvm.org/D93344
More information about the llvm-commits
mailing list