[PATCH] D92890: VFS: Return new file systems as uniquely owned when possible, almost NFC

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added a comment.

In D92890#2453582 <https://reviews.llvm.org/D92890#2453582>, @dblaikie wrote:

>> This is almost NFC, except that it fixes a memory leak in vfs::collectVFSFromYAML().
>
> Was this memory leak identified by any of the LLVM/Clang sanitizers, or at least valgrind? (if it was identified by sanitizers I wonder why it persisted so long, given we have sanitizer bots folks like to keep green, etc)

Not that I'm aware of, I just noticed it when I was in there. I'm not sure why `-fsanitize=address` never flagged this; I'd have thought in-tree clang tests using `-ivfsoverlay` would exercise this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92890/new/

https://reviews.llvm.org/D92890