[PATCH] D93332: [mac/lld] fill in current and compatibility version for LC_LOAD_(WEAK_)DYLIB

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 15 13:38:59 PST 2020


int3 accepted this revision.
int3 added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: lld/test/MachO/implicit-dylibs.s:45
+# LOAD-NEXT:            time stamp
+# LOAD-NEXT:       current version 1.1.1
+# LOAD-NEXT: compatibility version
----------------
I think stub-link.s might be a better place to test this, since it contains a variety of generic TBD-related tests, whereas this file is more specifically for implicit dylib behavior.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93332/new/

https://reviews.llvm.org/D93332



More information about the llvm-commits mailing list