[PATCH] D93326: [MCInstrDesc] [TableGen] Reduce size of MCOperandInfo instances

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/include/llvm/MC/MCInstrDesc.h:43
+
+#define MCOI_EARLY_CLOBBER(bit) \
+  ((1 << MCOI::EARLY_CLOBBER) | ((bit) << (4 + MCOI::EARLY_CLOBBER * 4)))
----------------
What is "bit" here? There's no data associated with EARLY_CLOBBER. The original code just did (1 << MCOI::EARLY_CLOBBER) to set the flag, there was nothing in the upper bits.


================
Comment at: llvm/utils/TableGen/InstrInfoEmitter.cpp:186
+        Res += "MCOI_EARLY_CLOBBER(1)";
+////        Res += "(1 << MCOI::EARLY_CLOBBER)";
       else {
----------------
Drop commented out code?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93326/new/

https://reviews.llvm.org/D93326