[PATCH] D93306: [llvm-symbolizer][Windows] Add start line when searching in line table sections.

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: llvm/test/tools/llvm-symbolizer/pdb/pdb-line-numbers.test:1
+RUN: llvm-symbolizer --obj="%p/Inputs/test-line-numbers.exe" \
+RUN:   --relative-address 0x1000 0x1003 0x1010 0x1013 | FileCheck %s
----------------
The input is an object file, not an executable, right? The input should end in .obj, not .exe, in that case.

However, why not make this an assembly test? Check in the generated .s file, which should have .cv_loc directives with line info, and it should be relatively readable.


================
Comment at: llvm/test/tools/llvm-symbolizer/pdb/pdb-line-numbers.test:5
+CHECK:      f1(int)
+CHECK-NEXT: t.cpp:2:13
+
----------------
This corresponds with the location of the brace, right? I think this will make more sense if you interleave it in a .s file after the corresponding .cv_loc directive with the t.cpp:2:13 location.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93306/new/

https://reviews.llvm.org/D93306