[PATCH] D91595: [Debugify] Support checking Machine IR debug info

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 15 11:49:34 PST 2020


vsk resigned from this revision.
vsk added a comment.

Hi @xiangzhangllvm, apologies for the delay.

> But if it makes things complex or down the readability, I prefer not merging.
> Currently, both IR/MIR check is very simple and clear, merging won't take profit.

Imo this overstates the difficulty of code sharing in this context, and underweights the potential long-term effects of having divergent code paths that are supposed to do the same thing. I urge you to reconsider :).

I'm not sure I'll have time to continue with this review, so I'll let other voices take over.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91595/new/

https://reviews.llvm.org/D91595



More information about the llvm-commits mailing list