[PATCH] D89845: Add the ability to extract the unwind rows from DWARF Call Frame Information.

Greg Clayton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 15 11:14:21 PST 2020


clayborg added a comment.

In D89845#2454273 <https://reviews.llvm.org/D89845#2454273>, @jhenderson wrote:

> Looks fine aside from the two outstanding comments re. error messages.

I commented that these are in dump functions that were already created before this patch. They are in the process of dumping the contents to the stream, so dumping the error messages to the stream seems most important. We don't want to stop dumping the information that people asked for due to running into a single error in a file as people will probably want see all of the errors in a file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89845/new/

https://reviews.llvm.org/D89845



More information about the llvm-commits mailing list